Re: [PATCH v3 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver
From: Adil Hüsrev Tepe
Date: Sun Nov 22 2026 - 02:53:12 EST
On Wed, 18 Nov 2026 10:53:39 +0100
Joshua Crofts <crofts@xxxxxxxxxx> wrote:
> Hi Adil, some comments inline.
Hi Joshua,
Thanks for the review, and for the note on the cover letter about the
threading and sending v3 the same day as v2. Both fair; v4 goes out as
a new thread, not before the end of the week.
I'll take all of these in v4: the include, the pahole layout,
fsleep(), plain "return ret" instead of dev_err_probe() on each regmap
call, the blank lines, PM_RUNTIME_ACQUIRE_AUTOSUSPEND(), dropping the
pm_runtime_dont_use_autosuspend() call, and the duplicate error message
after devm_request_threaded_irq().
Thanks,
Adil