Re: [PATCH] wifi: rtw89: read the beacon header from the frame data
From: Ping-Ke Shih
Date: Sat Nov 21 2026 - 22:57:49 EST
Shirong Zhao <shxzhaosr@xxxxxxx> wrote:
> rtw89_fw_h2c_update_beacon() and rtw89_fw_h2c_update_beacon_be()
> cast the sk_buff pointer itself to struct ieee80211_hdr to compute the
> TIM offset:
>
> hdr = (struct ieee80211_hdr *)skb_beacon;
>
> The 802.11 header lives in the frame data returned by
> ieee80211_beacon_get_tim(), not at the start of struct sk_buff, so the
> cast reads sk_buff metadata instead of frame_control.
>
> For a freshly allocated skb skb->next is NULL, the value read is 0 and
> ieee80211_hdrlen() happens to return the same 24 bytes as a real beacon
> header, which masks the bug. As soon as the skb is on a list the
> computed header length is garbage and the Group IE offset passed to the
> firmware is wrong.
>
> Point hdr at skb_beacon->data instead.
>
> Found by code inspection; not observed at runtime.
> Signed-off-by: Shirong Zhao <shxzhaosr@xxxxxxx>
> Tested-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
3e303ccc30f2 wifi: rtw89: read the beacon header from the skb data
---
https://github.com/pkshih/rtw.git