[RFC PATCH v6 16/26] signal: Support userland fds in pidfd_send_signal()
From: Jarkko Sakkinen
Date: Sat Nov 21 2026 - 20:20:07 EST
Signaling every process inside a userland from userspace via /proc is
racy against concurrent fork() calls.
Teach pidfd_send_signal() to dispatch userland file descriptors to
userland_send_signal() when info is NULL and flags is 0. Require an
ancestor active PID namespace, walk the userland's PID namespace IDR
under tasklist_lock, and deliver a validated signal once to each thread
group including in-flight forks, aggregating per-process delivery
results.
Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
---
include/linux/userland.h | 10 +++++++
kernel/signal.c | 4 +++
kernel/userland.c | 59 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 73 insertions(+)
diff --git a/include/linux/userland.h b/include/linux/userland.h
index 1bab10d931b5..173c22c27ae9 100644
--- a/include/linux/userland.h
+++ b/include/linux/userland.h
@@ -17,6 +17,7 @@ struct nsproxy;
struct pid;
struct pid_namespace;
struct rusage;
+struct siginfo;
struct task_struct;
struct user_namespace;
struct waitid_info;
@@ -49,6 +50,8 @@ void userland_copy(struct task_struct *tsk, struct pid *pid,
void userland_exit(struct pid_namespace *pid_ns, struct task_struct *tsk);
long userland_waitid(int upid, struct waitid_info *infop, int options,
struct rusage *ru);
+int userland_send_signal(struct file *file, int sig,
+ struct siginfo __user *info, unsigned int flags);
#else
static inline void userland_put(struct userland *c)
{
@@ -74,6 +77,13 @@ static inline long userland_waitid(int upid, struct waitid_info *infop,
{
return -EINVAL;
}
+
+static inline int userland_send_signal(struct file *file, int sig,
+ struct siginfo __user *info,
+ unsigned int flags)
+{
+ return -EBADF;
+}
#endif /* CONFIG_USERLAND */
#endif /* _LINUX_USERLAND_H */
diff --git a/kernel/signal.c b/kernel/signal.c
index dd770e68faee..5b11e67dc98a 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -37,6 +37,7 @@
#include <linux/capability.h>
#include <linux/freezer.h>
#include <linux/pid_namespace.h>
+#include <linux/userland.h>
#include <linux/nsproxy.h>
#include <linux/user_namespace.h>
#include <linux/uprobes.h>
@@ -4181,6 +4182,9 @@ SYSCALL_DEFINE4(pidfd_send_signal, int, pidfd, int, sig,
if (fd_empty(f))
return -EBADF;
+ if (userland_is_file(fd_file(f)))
+ return userland_send_signal(fd_file(f), sig, info, flags);
+
/* Is this a pidfd? */
pid = pidfd_to_pid(fd_file(f));
if (IS_ERR(pid))
diff --git a/kernel/userland.c b/kernel/userland.c
index c118defcff01..739f6b98c103 100644
--- a/kernel/userland.c
+++ b/kernel/userland.c
@@ -287,6 +287,65 @@ long userland_waitid(int upid, struct waitid_info *infop, int options,
return ret;
}
+/**
+ * DOC: pidfd_send_signal
+ *
+ * ``pidfd_send_signal(userland_fd, sig, NULL, 0)`` delivers ``sig`` (or ``0`` for
+ * a permission and existence probe) once to each member thread group in a
+ * running userland. ``info`` must be ``NULL``, ``flags`` must be ``0``, and the
+ * caller must run in an ancestor active PID namespace.
+ */
+int userland_send_signal(struct file *file, int sig,
+ struct siginfo __user *info, unsigned int flags)
+{
+ struct userland *userland = file->private_data;
+ struct pid_namespace *pid_ns = userland->ns->pid_ns_for_children;
+ bool any_success = false;
+ bool any_other = false;
+ bool any_perm = false;
+ int other_err = 0;
+ struct pid *pid;
+ int nr;
+
+ if (info || flags || sig < 0 || !valid_signal(sig))
+ return -EINVAL;
+ if (!pidns_is_ancestor(pid_ns, task_active_pid_ns(current)))
+ return -EXDEV;
+ if (READ_ONCE(userland->state) != USERLAND_RUNNING)
+ return -ESRCH;
+
+ scoped_guard(rcu) {
+ read_lock(&tasklist_lock);
+ idr_for_each_entry(&pid_ns->idr, pid, nr) {
+ struct task_struct *task = pid_task(pid, PIDTYPE_TGID);
+ int err;
+
+ if (!task)
+ continue;
+
+ err = group_send_sig_info(sig, SEND_SIG_NOINFO, task,
+ PIDTYPE_MAX);
+ if (!err) {
+ any_success = true;
+ } else if (err == -EPERM) {
+ any_perm = true;
+ } else if (err != -ESRCH && !any_other) {
+ any_other = true;
+ other_err = err;
+ }
+ }
+ read_unlock(&tasklist_lock);
+ }
+
+ if (any_success)
+ return 0;
+ if (any_other)
+ return other_err;
+ if (any_perm)
+ return -EPERM;
+ return -ESRCH;
+}
+
static long userland_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
{
struct userland *userland = file->private_data;
--
2.47.3