Re: checkpatch: false positive "Alignment should match open parenthesis" with struct_group_tagged()
From: Marc Kleine-Budde
Date: Sat Nov 21 2026 - 17:15:27 EST
On 21.11.2026 13:51:05, Joe Perches wrote:
> > it seems that all users of struct_group_tagged() in the kernel indent
> > with 1 tab, like this:
> >
> > > struct gs_host_frame {
> > > struct_group_tagged(gs_host_frame_header, header,
> > > u32 echo_id;
> > > __le32 can_id;
> > >
> > > u8 can_dlc;
> > > u8 channel;
> > > u8 flags;
> > > u8 reserved;
> > > );
>
> Thanks for the report, but I don't care.
> It's just an unusual macro mechanism.
>
> include/linux/stddef.h:#define struct_group_tagged(TAG, NAME, MEMBERS...) \
...it isn't used that often anyway :) and it's only on the "CHECK" level.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature