Re: [PATCH v2] iio: gyro: adxrs290: propagate chip ID read errors
From: Jonathan Cameron
Date: Sat Nov 21 2026 - 17:03:53 EST
On Fri, 20 Nov 2026 11:40:18 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Nov 20, 2026 at 10:57:54AM +0800, Siqi Chen wrote:
> > spi_w8r8() returns either an unsigned 8-bit value or a negative error.
> > The probe function stores its return value in a u8, truncating errors and
> > treating them as unexpected chip IDs. Consequently, an SPI transfer failure
> > is reported as -ENODEV instead of the actual error.
> >
> > Store each result in an int and return negative errors before validating
> > the chip IDs.
>
> ...
>
> > - Move the OpenCode disclosure and testing information below the
> > separator.
>
> It's interesting that the other patch without this amendment was sent just
> a half an hour before this one. If you get a comment against one, check all
> the rest (at least for the same subsystem). Always.
>
Applied to the testing branch of iio.git.
Thanks,
Jonathan