Re: [RFC PATCH v2 01/15] misc/arm-cla: Add driver skeleton and documentation
From: Linus Walleij
Date: Sat Nov 21 2026 - 16:19:37 EST
Hi Ryan, Jean-Philippe,
On Thu, Oct 15, 2026 at 4:26 PM Ryan Roberts <ryan.roberts@xxxxxxx> wrote:
> +/**
> + * struct cla_dev - CLA device
> + *
> + * Immutable state:
> + * @cpu: The CPU this CLA is attached to.
> + * @dev: The platform device.
> + */
> +struct cla_dev {
Don't abbreviate compulsively, cla is fine, I would
call it cla_device.
> + unsigned int cpu;
> + struct device *dev;
> +};
I will argue in other patches that this should be a proper
struct device and not a pointer to a platform_devcive
&pdev->dev.
Yours,
Linus Walleij