Re: [PATCH v2 5/7] iio: adc: qcom-spmi-adc5-gen3: Remove Gen3 virtual channel macros
From: Jonathan Cameron
Date: Sat Nov 21 2026 - 16:09:04 EST
On Fri, 20 Nov 2026 14:49:45 +0530
Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx> wrote:
> Now that the Gen3 virtual channel macros have been replaced with Gen4
> macros in both main IIO ADC driver and auxiliary ADC_TM driver, remove
> the Gen3 macros as they are no longer used.
>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
Ah. Ok. I missed this was coming.
Perhaps modifying these to align in earlier patches is to much
pain given you are going to delete them.
Ignore those comments.
Thanks,
Jonathan
> ---
> include/linux/iio/adc/qcom-adc5-gen3-common.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/iio/adc/qcom-adc5-gen3-common.h b/include/linux/iio/adc/qcom-adc5-gen3-common.h
> index fa7e08d67f26..105b0766a01f 100644
> --- a/include/linux/iio/adc/qcom-adc5-gen3-common.h
> +++ b/include/linux/iio/adc/qcom-adc5-gen3-common.h
> @@ -40,7 +40,6 @@
> #define ADC5_GEN3_CONV_ERR_CLR_REQ BIT(0)
>
> #define ADC5_GEN3_SID 0x4f
> -#define ADC5_GEN3_SID_MASK GENMASK(3, 0)
> #define ADC5_GEN4_SID_MASK GENMASK(4, 0)
> #define ADC5_GEN4_BUS_INDEX_MASK GENMASK(6, 5)
>
> @@ -78,10 +77,6 @@
> #define ADC5_GEN3_CONV_REQ 0xe5
> #define ADC5_GEN3_CONV_REQ_REQ BIT(0)
>
> -#define ADC5_GEN3_VIRTUAL_SID_MASK GENMASK(15, 8)
> -#define ADC5_GEN3_CHANNEL_MASK GENMASK(7, 0)
> -#define ADC5_GEN3_V_CHAN(x) \
> - (FIELD_PREP(ADC5_GEN3_VIRTUAL_SID_MASK, (x).sid) | (x).channel)
> #define ADC5_GEN4_V_CHAN_BUS_INDEX_MASK GENMASK(14, 13)
> #define ADC5_GEN4_V_CHAN_SID_MASK GENMASK(12, 8)
> #define ADC5_GEN4_V_CHAN_CHANNEL_MASK GENMASK(7, 0)
>