[PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status
From: Omokefe Emmanuel Onanaroghene
Date: Sat Nov 21 2026 - 13:23:08 EST
Four checks in tools/testing/selftests/net/veth.sh report failures
without setting ret, allowing the script to exit 0 even when a check
fails. Set ret=1 in chk_channels() and the three "bad setting"
negative tests identified by Tianyi during review of v2.
Patch 1 fixes the invalid TX channel test, which used nproc + 1
to determine an out-of-range value. However, nproc can be lower
than num_possible_cpus() when CPU affinity or cpusets restrict
a process, meaning the kernel may accept the requested queue count.
This could cause false failures on a correctly functioning
kernel once earlier patches propagated test failures.
Use the kernel-reported max_tx + 1 instead, ensuring the
attempted value always exceeds the device's supported maximum.
Spotted by Sashiko AI review of v2.
---
v5:
- Retarget to net-next and drop the Fixes tags
- Move the invalid-tx fix first, so no commit in the series can
report a false failure on a correct kernel.
- Fix the subject prefix on the invalid-tx patch, lost in v4's
send.
v4: https://lore.kernel.org/all/20261119003003.40482-1-emmaonana18@xxxxxxxxx/
- Patch 2: use if/else instead of "&& { ...; } ||" chains, keep
lines within 80 columns (thanks Tianyi for the review).
- Add patch 3 deriving the invalid tx value from the kernel maximum.
v3: https://lore.kernel.org/all/20261116084107.6675-1-emmaonana18@xxxxxxxxx/
- Add Tianyi Gao's Tested-by to patch 1.
- Add patch 2 fixing the remaining three checks.
v2: https://lore.kernel.org/all/20261115214702.50817-1-emmaonana18@xxxxxxxxx/
- Correct Fixes tag to 1ec2230fc721.
v1: https://lore.kernel.org/all/20261115212117.48496-1-emmaonana18@xxxxxxxxx/
- Initial posting.
Omokefe Emmanuel Onanaroghene (3):
selftests: net: veth: derive invalid-tx test value from kernel max
selftests: net: veth: propagate channel-check failures to exit status
selftests: net: veth: propagate bad-settings check failures to exit
status
tools/testing/selftests/net/veth.sh | 31 +++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
--
2.43.0