Re: [PATCH ath-next v3 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575

From: Krzysztof Kozlowski

Date: Sat Nov 21 2026 - 07:34:08 EST


On Wed, Nov 18, 2026 at 01:45:29PM +0530, Madhavan Ganesan wrote:
> + .hw_ops = NULL,
> + .ring_mask = NULL,
> +
> + .host_ce_config = NULL,
> + .ce_count = 16,
> + .target_ce_config = NULL,
> + .target_ce_count = 0,
> + .svc_to_ce_map = NULL,
> + .svc_to_ce_map_len = 0,
> +
> + .rxdma1_enable = false,
> + .num_rxdma_per_pdev = 0,
> + .num_rxdma_dst_ring = 0,
> + .rx_mac_buf_ring = false,
> + .vdev_start_delay = false,
> +
> + .interface_modes = BIT(NL80211_IFTYPE_STATION) |
> + BIT(NL80211_IFTYPE_AP) |
> + BIT(NL80211_IFTYPE_MESH_POINT),
> + .supports_monitor = false,
> + .supports_cong_ctrl_max_msdus = false,
> +
> + .idle_ps = false,
> + .download_calib = true,
> + .supports_suspend = false,
> + .tcl_ring_retry = false,
> + .reoq_lut_support = false,
> + .supports_shadow_regs = false,
> +
> + .num_tcl_banks = 0,
> + .max_tx_ring = 0,
> +
> + .mhi_config = NULL,
> +
> + .wmi_init = NULL,

Why do you add NULL assignments, which are not even correct because
immediately in next patch you remove them?

Adding code which you remove is clear sign this is wrongly set and
confusing code.

Add complete features or code, not somerthing which you know that it is
incorrect.

Best regards,
Krzysztof