Re: [PATCH] mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
From: David Hildenbrand (Arm)
Date: Fri Nov 20 2026 - 04:59:54 EST
On 11/14/26 18:31, Lorenzo Stoakes (ARM) wrote:
> On Sun, Nov 15, 2026 at 12:47:08AM +0800, shao.mingyin@xxxxxxxxxx wrote:
>> From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
>>
>> mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
>>
>> A balloon driver's -ENOENT migration result means that the old page was
>> deflated but the replacement was not inflated. vmw_balloon returns this
>> when its deflate operation succeeds and the subsequent inflate fails.
>>
>> balloon_page_migrate() accounts the deflation and frees the old page,
>> but does not decrement NR_BALLOON_PAGES. Each such failure therefore
>> leaves one extra page in the per-node count, which also contributes to
>> the Balloon value in /proc/meminfo.
>>
>> Decrement the counter on the old page's node, matching normal dequeue
>> accounting.
>>
>> Fixes: 4d689474e1b2 ("balloon_compaction: update the NR_BALLOON_PAGES state")
>> Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
>
> NAK.
>
> this is generated by some AI slopper's script, spamming the kernel. The
> patches I looked at were wrong/broken, so no to anything from this person.
>
> They've sent 300 mails in under four weeks spanniing: ata, scsi, target,
> ufs, nvme/nvmet, ubifs, ublk, zloop, dm, md, mmc, virtio-blk, mfd, gpio,
> pwm, spi, PCI, ASoC, ACPI, net, vfs mount, block partitions, and now mm.
>
> and 17 series across 7 subsystems over the past 23 hours.
>
> We need a way to ban emails from people like this...
Yeah, that's absolutely annoying. In particular as we REQUIRE people to
understand the changes they submit, and own the code.
That clearly won't happen in this case.
There is a real (low prio) bug hiding in there, so something to be fixed. I'll
take care of it.
I'll take care of it.
--
Cheers,
David