Re: [PATCH] ALSA: ump: Fix dropped data bytes at UMP System message conversion

[Takashi Iwai]

On Thu, 29 Oct 2026 14:05:37 +0100,
HyeongJun An wrote:
> 
> The cvt_ump_system_to_legacy() function switches on
> ump_message_status_code(), which returns only the upper 4 bits of the
> status. The case labels are the full 0xf1, 0xf2 and 0xf3 values, so they
> never match. MIDI Time Code, Song Position and Song Select are converted
> to the status byte alone, and their data bytes are lost.
> 
> Switch on the full status byte in buf[0] instead.
> 
> Both callers of snd_ump_convert_from_ump() pass the result on as is: the
> legacy rawmidi input of a UMP endpoint, and the MIDI 1.0 path of the
> f_midi2 USB gadget.
> 
> Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: HyeongJun An <sammiee5311@xxxxxxxxx>

Applied now.  Thanks.


Takashi