Re: [PATCH v2 0/4] tools/bootconfig: Preserve tracing settings during export

[Masami Hiramatsu (Google)]

On Sat, 31 Oct 2026 22:07:08 +0900, Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:
> On Sat, 31 Oct 2026 11:25:30 +0100, Eduardo Mucelli Rezende Oliveira <edumucelli@xxxxxxxxx> wrote:
> > Hi Masami,
> > 
> > Thanks for the review. I've updated the event-filter patch to use the
> > explicit delimiter pattern you suggested. It now warns and skips filters
> > that contain delimiters and both quote types, since bootconfig cannot
> > represent them. The other three patches are unchanged.
> > 
> > Changes in v2:
> > - Patch 1: use explicit escapes in *[,\;\#\}]* for the delimiter check.
> >   The semicolon also needs escaping for the shell to parse the pattern.
> > - Patch 1: detect both quote types, warn on stderr and skip the filter.
> > - Patches 2-4: no changes.
> > 
> > The series keeps event filters, generic trigger counts, histogram
> > variable ordering and paused histogram state during export. It is still
> > based on bootconfig/fixes, including the two fixes you picked up earlier.
> > 
> > I retested the filter change in a temporary tracefs instance on my Ubuntu
> > machine, running kernel 7.0.0-38-generic, with recording disabled. I also
> > checked the mixed-quote cases against real tracefs filters and added
> > regression checks for both quote orders and all four delimiters. The
> > fixture checks cover each fix and the full series.
> 
> Thanks, this series looks good to me. Let me pick those.

BTW, I will move these fixes (including your previous series of patches)
to bootcofig/core, instead of bootconfig/fixes, because it fixes a script
which is not related to kernel build/boot process but just helping specific
users - who can easily get the latest kernel.

Thanks,

-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>