Re: [PATCH 1/4] gpu: nova-core: fix stride of NV_PFSP_* registers

[John Hubbard]

On 10/30/26 12:41 AM, Alexandre Courbot wrote:
> OpenRM defines these registers with a stride of 8 bytes, so reflect that
> fact in our own declarations. That inconsistency went unnoticed because
> nova-core only ever uses the first register of each array at the moment.
> 
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
>  drivers/gpu/nova-core/regs.rs | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>

thanks,
-- 
John Hubbard

> 
> diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
> index 88662da634dc..df2eddc58efb 100644
> --- a/drivers/gpu/nova-core/regs.rs
> +++ b/drivers/gpu/nova-core/regs.rs
> @@ -402,19 +402,19 @@ pub(crate) fn mem_scrubbing_done(self) -> bool {
>  register! {
>      base: NovaRegisters;
>  
> -    pub(crate) NV_PFSP_QUEUE_HEAD(u32)[8] @ 0x008f2c00 {
> +    pub(crate) NV_PFSP_QUEUE_HEAD(u32)[8, stride = 8] @ 0x008f2c00 {
>          31:0    address => u32;
>      }
>  
> -    pub(crate) NV_PFSP_QUEUE_TAIL(u32)[8] @ 0x008f2c04 {
> +    pub(crate) NV_PFSP_QUEUE_TAIL(u32)[8, stride = 8] @ 0x008f2c04 {
>          31:0    address => u32;
>      }
>  
> -    pub(crate) NV_PFSP_MSGQ_HEAD(u32)[8] @ 0x008f2c80 {
> +    pub(crate) NV_PFSP_MSGQ_HEAD(u32)[8, stride = 8] @ 0x008f2c80 {
>          31:0    val => u32;
>      }
>  
> -    pub(crate) NV_PFSP_MSGQ_TAIL(u32)[8] @ 0x008f2c84 {
> +    pub(crate) NV_PFSP_MSGQ_TAIL(u32)[8, stride = 8] @ 0x008f2c84 {
>          31:0    val => u32;
>      }
>  }
>