Re: [PATCH v10 tip/sched/core 6/6] sched/debug: Introduce per-CPU debugfs files

[Aaron Tomlin]

On Fri, Oct 30, 2026 at 11:35:03AM +0530, K Prateek Nayak wrote:
> Hello Aaron,
> 
> On 10/30/2026 7:08 AM, Aaron Tomlin wrote:
> > +static __init void debugfs_cpu_init(void)
> > +{
> > +	struct dentry *d_cpu_dir;
> > +	unsigned long cpu;
> > +	char buf[16];
> > +
> > +	d_cpu_dir = debugfs_create_dir("cpu", debugfs_sched);

Hi Prateek,

Thank you for your feedback.

> Missing an error handling here in case this fails?

Not checking the return value of debugfs_create_dir() is not only common,
it is the intentional and canonical design across the Linux kernel.

This matches the existing pattern in sched_init_debug().


Kind regards,
-- 
Aaron Tomlin