Re: [PATCH v5 10/15] drm/rockchip: vop2: Switch to enum vop_csc_format
From: Daniel Stone
Date: Fri Oct 30 2026 - 07:52:02 EST
On Tue, 13 Oct 2026 at 23:51, Cristian Ciocaltea
<cristian.ciocaltea@xxxxxxxxxxxxx> wrote:
> Improve code readability in vop2_setup_csc_mode() by using enum
> vop_csc_format for the csc_mode variable, as well as for the return type
> of the vop2_convert_csc_mode() helper, which already returns CSC_*
> enumerators.
>
> While at it, replace the nonsensical 'csc_mode = false' assignment in
> the no-conversion branch with the equivalent CSC_BT601L, which carries
> the same value (0) but is type-correct.
Reviewed-by: Daniel Stone <daniels@xxxxxxxxxxxxx>