Re: [PATCH v2 2/2] staging: iio: addac: adt7316: explicitly include missing headers and sort
From: Joshua Crofts
Date: Fri Oct 30 2026 - 07:47:56 EST
On Fri, 30 Oct 2026 12:47:45 +0200
Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx> wrote:
> Explicitly include <linux/err.h>, <linux/errno.h>, <linux/pm.h>,
> <linux/string.h>, and <linux/types.h> for error handling, error codes,
> EXPORT_GPL_SIMPLE_DEV_PM_OPS(), memcmp(), and fixed-width types. Drop
> unused headers and sort the remaining headers alphabetically.
>
Better if patch 1 only sorts the list and patch 2 removes kernel.h
and adds/removes headers - it will be more readable that way. Have
a look at this patch series I sent some time ago [1] for reference.
[1] https://lore.kernel.org/all/20260831-kernel-header-removal-v2-0-b92b580ef5eb@xxxxxxxxx/
--
Kind regards,
Joshua Crofts