Re: [PATCH 02/11] dt-bindings: media: amlogic,s4-vdec: describe both decoder cores

[Krzysztof Kozlowski]

On Sun, Oct 25, 2026 at 08:24:58PM +0100, christian.koever-draxl@xxxxxxxxxxxxxxxxxx wrote:
> From: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
> 
> The S4 video decoder has two cores: VDEC for H.264, MPEG-1/2 and MJPEG,
> and the HEVC core for HEVC, VP9 and AV1. Update the description and
> name the individual reg, interrupt, clock and power-domain entries.
> 
> Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
> ---
>  .../bindings/media/amlogic,s4-vdec.yaml       | 24 ++++++++++++++-----
>  1 file changed, 18 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> index e3c2ab4000aa..6c98d7013029 100644
> --- a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml

There is no such file. Do not send in-flight patches with fixes, just
fix the source.

> @@ -11,15 +11,19 @@ maintainers:

>    - Zhentao Guo <zhentao.guo@xxxxxxxxxxx>
>  
>  description:
> -  The Video Decoder Accelerator present on Amlogic SOCs.
> -  It supports stateless h264 decoding.
> +  The video decoder (DOS block) of the Amlogic S4 family. It has two cores,
> +  VDEC for H.264, MPEG-1/2, MPEG-4 Part 2 and MJPEG, and the HEVC core for
> +  HEVC, VP9 and AV1. Both run microcode that the secure world loads, and
> +  are exposed as a stateless V4L2 decoder.
>  
>  properties:
>    compatible:
>      const: amlogic,s4-vdec
>  
>    reg:
> -    maxItems: 2
> +    items:
> +      - description: DOS register block, both decoder cores
> +      - description: DMC request control, gates the cores' memory requests
>  
>    reg-names:
>      items:
> @@ -27,10 +31,16 @@ properties:
>        - const: dmc
>  
>    interrupts:
> -    maxItems: 3
> +    items:
> +      - description: HEVC core
> +      - description: VDEC core
> +      - description: third DOS mailbox, not used by the decoder
>  

Aren't you just duplicating names properties? I would check... if that
file ever existed :/

Best regards,
Krzysztof