Re: [PATCH 3/4] drm/panel: innolux-p079zca: Use mipi_dsi_*_multi(); fix minor bugs

[Doug Anderson]

Hi,

On Mon, Oct 12, 2026 at 9:36 PM Akash Sukhavasi
<akash.sukhavasi@xxxxxxxxx> wrote:
>
> @@ -108,24 +103,18 @@ static int innolux_panel_prepare(struct drm_panel *panel)
>                         goto poweroff;
>         }
>
> -       err = mipi_dsi_dcs_exit_sleep_mode(innolux->link);
> -       if (err < 0) {
> -               dev_err(panel->dev, "failed to exit sleep mode: %d\n", err);
> -               goto poweroff;
> -       }
> -
> +       mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);

The patch looks fine and I'm OK with applying it.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

However, it could be better. Specifically, you could change the
".init" callback to take the "dsi_ctx" that you've declared in
innolux_panel_prepare(). Then it doesn't need to return an error and
you can get rid of the whole error check after the call

  if (err < 0)
    goto poweroff;

That could be a nice follow-up patch.


-Doug