Re: [PATCH v3 12/16] drm/msm/a8xx: devcoredump state capture support

[Alexander Koskovich]

On Thursday, October 29th, 2026 at 4:20 PM, Rob Clark <robin.clark@xxxxxxxxxxxxxxxx> wrote:

> +static struct adreno_snapshot_sect
> +__snapshot_sect_init(struct adreno_gpu_state *state, uint16_t id, size_t extra_sz,
> +		     void *sect_hdr, size_t sect_hdr_sz, const char *func, int line)
> +{
> +	/* A few section types have no section header: */
> +	switch (id) {
> +	case ADRENO_SNAPSHOT_SECTION_REGS_V2:
> +		sect_hdr_sz = 0;
> +	default:
> +		break;
> +	}

Heads up that I'm seeing this warning when building with clang:

In file included from ../drivers/gpu/drm/msm/adreno/a8xx_gpu_state.c:9:
../drivers/gpu/drm/msm/adreno/adreno_snapshot.h:398:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
  398 |         default:
      |         ^
../drivers/gpu/drm/msm/adreno/adreno_snapshot.h:398:2: note: insert 'break;' to avoid fall-through
  398 |         default:
      |         ^
      |         break;

Thanks,
Alex