Re: [PATCH RFC 11/18] dt-bindings: firmware: add A210 SCMI clock and reset IDs

[Conor Dooley]

On Tue, Oct 27, 2026 at 11:37:02PM +0800, Han Gao via B4 Relay wrote:
> From: Han Gao <gaohan@xxxxxxxxxxx>
> 
> Define the SCMI clock and reset IDs for the A210 UARTs, pad controllers
> and AON I2C1. Each UART has separate serial and APB reset lines, so
> they get separate reset IDs, numbered like the matching clocks.

Drivers will never use these, it's all just passthrough - is it actually
a binding at all or should it be in the dts directory as a header there?

Given this can change with firmware versions, and isn't fixed, I don't
think it is actually a binding.

> 
> Signed-off-by: Han Gao <gaohan@xxxxxxxxxxx>
> ---
>  include/dt-bindings/clock/zhihe,a210-scmi.h | 15 +++++++++++++++
>  include/dt-bindings/reset/zhihe,a210-scmi.h | 13 +++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/include/dt-bindings/clock/zhihe,a210-scmi.h b/include/dt-bindings/clock/zhihe,a210-scmi.h
> new file mode 100644
> index 000000000000..b8f6441ac650
> --- /dev/null
> +++ b/include/dt-bindings/clock/zhihe,a210-scmi.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +#ifndef _DT_BINDINGS_CLOCK_ZHIHE_A210_SCMI_H_
> +#define _DT_BINDINGS_CLOCK_ZHIHE_A210_SCMI_H_
> +
> +/* SCMI clock IDs; existing entries must not be renumbered. */
> +#define A210_CLK_UART_SCLK(n) (n)
> +#define A210_CLK_UART_PCLK(n) (10 + (n))
> +#define A210_CLK_PERI1_PAD 20
> +#define A210_CLK_PERI2_PAD 21
> +#define A210_CLK_PERI3_PAD 22
> +#define A210_CLK_AON_SYS 23
> +#define A210_CLK_AON_I2C1_IC 24
> +#define A210_CLK_AON_I2C1_PCLK 25
> +
> +#endif
> diff --git a/include/dt-bindings/reset/zhihe,a210-scmi.h b/include/dt-bindings/reset/zhihe,a210-scmi.h
> new file mode 100644
> index 000000000000..53e108c15407
> --- /dev/null
> +++ b/include/dt-bindings/reset/zhihe,a210-scmi.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +#ifndef _DT_BINDINGS_RESET_ZHIHE_A210_SCMI_H_
> +#define _DT_BINDINGS_RESET_ZHIHE_A210_SCMI_H_
> +
> +/* SCMI reset IDs; existing entries must not be renumbered. */
> +#define A210_RESET_UART_SRST(n) (n)
> +#define A210_RESET_UART_PRST(n) (10 + (n))
> +#define A210_RESET_PERI1_PAD 20
> +#define A210_RESET_PERI2_PAD 21
> +#define A210_RESET_PERI3_PAD 22
> +#define A210_RESET_AON_I2C1 23
> +
> +#endif
> 
> -- 
> 2.55.0
> 
>

Attachment: signature.asc
Description: PGP signature