Re: [PATCH] block: Keep RPM_ACTIVE in blk_pre_runtime_resume() when already active
From: Bart Van Assche
Date: Thu Oct 29 2026 - 12:33:26 EST
On 10/29/26 12:08 AM, Stanley Jhu wrote:
2. The first runtime resume fails in the driver callback, and
blk_post_runtime_resume() sets q->rpm_status to RPM_ACTIVE and calls
blk_clear_pm_only(), decrementing q->pm_only from 1 to 0 so recovery
commands can enter the queue (intended since
commit 6e1fcab00a23 ("scsi: block: pm: Always set request queue
runtime active in blk_post_runtime_resume()")).
q->rpm_status should be changed back to RPM_SUSPENDED if a runtime
resume fails. The changes made my this patch don't look right to me.
Bart.