Re: [PATCH net] idpf: free the skb on TX DMA mapping errors

[Simon Horman]

On Mon, Oct 26, 2026 at 02:39:40PM -0700, Naman Gulati wrote:
> On Sat, Oct 24, 2026 at 8:04 PM <netdev-bot+sashiko@xxxxxxxxxx> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue(s) to consider.
> >
> > Critical: 0 · High: 1 · Medium: 0 (1) · Low: 0
> >
> > If you believe none of the issues are legitimate, please reply to each
> > issue of Medium severity or higher and explain why the AI is wrong.
> > If any of them are legitimate and you plan to respin, please let patchwork
> > know by including "pw-bot: cr" as a separate line at the end of your reply
> > (one such reply per series is enough).
> >
> > - [High] The fix leaves the skb leak in place for HW-timestamped packets,
> >   and the Tx timestamp latch they hold is also never released.
> 
> Both issues are pre-existing. This patch does not introduce any leaks
> and these should handled separately in the tx tstamp and FLOW_SCH_EN
> code paths.

Thanks, agreed.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>