Re: [PATCH 2/2] ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC

[Jacky Huang]

Hi Krzysztof,

Thanks for taking the time to review this.

On Thu, Oct 29, 2026 at 10:53:52AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Oct 29, 2026 at 01:58:08PM +0900, Jacky Huang wrote:
> > +	chosen {
> > +		bootargs = "console=tty0 console=ttyS4,115200n8 earlycon";
>
> Drop bootargs. Console (and baudrate) goes to stdout-path. earlycon is
> for debugging, not mainline wide-usage.

Will drop bootargs and use stdout-path = "serial4:115200n8" in v2.

[ ... ]

> > +							/* CPU0 IROT/thermal/SOCAMM/JTAG */
> > +							pca9555@50 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> If you cannot find a name matching your device, please check in kernel
> sources for similar cases or you can grow the spec (via pull request to
> DT spec repo).

Will rename the GPIO expanders to gpio@ and the fan controllers to
fan-controller@ in v2.

[ ... ]

> > +		gpio-line-names =
> > +		"B0_M1_MCU_RESET_L-O",
>
> Messed indentation.
>
> Are you sure you run dt-check-style here?

Will fix the indentation of all gpio-line-names in v2. Thanks for
pointing it out. I did run it and it passed, but it looks like the
continuation alignment check only considers values that start on the
same line as the '=', so this case wasn't caught.

Best regards,
Jacky