Re: [PATCH v3 2/6] dt-bindings: ata: sata-brcm: Describe the NSP IDM registers

[Krzysztof Kozlowski]

On Mon, Oct 26, 2026 at 12:16:14PM -0700, Florian Fainelli wrote:
> Northstar Plus uses the SATA IDM block to enable the interface clock and
> deassert the core reset before accessing the controller registers.

And which compatible in the binding is "Northstar Plus"? I tried to map
them to arm/bcm/brcm,nsp.yaml but nothing is there, so it looks like you
are making changes without having actual compatible documented. In that
case this is not needed. Make changes WITH documenting new compatible.

> 
> Allow an optional third register region named "idm" for the NSP
> controller. Keep other compatibles limited to their existing two
> register regions and allow older NSP descriptions without the IDM.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> ---
>  .../bindings/ata/brcm,sata-brcm.yaml          | 20 ++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> index fe7f091e744f..98529784b1fa 100644
> --- a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> +++ b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> @@ -15,6 +15,21 @@ maintainers:
>  
>  allOf:
>    - $ref: ahci-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: brcm,bcm-nsp-ahci
> +    then:
> +      properties:
> +        reg:
> +          description: AHCI, top control and optional IDM register regions
> +    else:
> +      properties:
> +        reg:
> +          maxItems: 2
> +        reg-names:
> +          maxItems: 2

Please move entire allOf to the bottom, before "unevaluatedProperties"
line.

Best regards,
Krzysztof