Re: [PATCH v5 13/16] printk: Try to register each console as Braille first

[Chris Down]

Petr Mladek writes:
>Braille consoles are unique: they can only be enabled via the command
>line and use the preferred console framework for initialization, yet
>they are never added to the console_list or associated with
>/dev/console. Because of this, the preferred_console variable remains
>unset when only a Braille console is requested.

This also changes what happens when the same driver is wanted both ways, which 
might be worth a sentence in the commit message.

For example:

    console=ttyS1 console=brl,ttyS0

Here we used to end up with ttyS1 as a normal console and the Braille request 
was silently ignored. Now ttyS0 becomes the Braille console, and every later 
register_console() from serial core goes to the Braille round and gets -ENODEV 
from braille_register_console(), so there is no serial console at all.

I think this is probably fine, but just needs clarifying in the commit message.

>+		 * @try_only_braille and @user_specifified define which

-> @user_specified

>@@ -4033,6 +4061,24 @@ static int try_enable_console(struct console *newcon)
> {
> 	int err;
> 
>+	/*
>+	 * First, try to enable the console driver as a Braille console.
>+	 * It would have metadata in the preferred_consoles[] array.
>+	 * But it won't be counted as @preferred_console because

"@preferred_console" is preferred_dev_console now, and it is a variable rather 
than a parameter, so no "@".

With those:

Acked-by: Chris Down <chris@xxxxxxxxxxxxxx>

Thanks!