RE: [RFC PATCH 12/15] virt: tdx-guest: Support Trust Device Interface (TDI) activation

From: Duan, Zhenzhong

Date: Wed Oct 28 2026 - 22:25:45 EST




>-----Original Message-----
>From: Jason Gunthorpe <jgg@xxxxxxxxxx>
>Subject: Re: [RFC PATCH 12/15] virt: tdx-guest: Support Trust Device
>Interface (TDI) activation
>
>On Wed, Oct 28, 2026 at 06:44:57AM +0000, Duan, Zhenzhong wrote:
>> >But this patch already calls dma_set_cc_private(). Will it cause problem
>> >without
>> >the following patch? If so, it has bisect issue.
>>
>> Agreed, it make more sense to move dma_set_cc_private() call into
>enable_dma() callback.
>
>I would be happier if the tsm drivers don't try to do anything with
>DMA API. Let the core code do it.
>
>The drivers should just implement the PCIe side of things, lock,
>unlock, run.


Yes, that would be ideal.

Thanks
Zhenzhong