Re: [PATCH v4 2/5] serial: 8250: share the RX trigger conversion helper

From: Andy Shevchenko

Date: Wed Oct 28 2026 - 05:42:45 EST


On Wed, Oct 28, 2026 at 10:30:07AM +0200, Ilpo Järvinen wrote:
> On Tue, 27 Oct 2026, James Hilliard wrote:

...

> > +static inline int serial8250_bytes_to_fcr(const unsigned char *rxtrig_bytes,
>
> This looks way to complicated to be inline function so I think it should
> be kept in 8250_port and exported from there.

Fine by me! James, my tags I gave in another reply stays if you move to
exported function.

--
With Best Regards,
Andy Shevchenko