[PATCH v2] mfd: dln2: Clean up dln2_unregister_event_cb() loop logic
From: Riccardo Oliva
Date: Tue Oct 27 2026 - 22:17:52 EST
Streamline dln2_unregister_event_cb() by using a dedicated 'entry'
pointer to store the matching event callback. This removes the need
for the 'found' boolean flag, restricts the iterator scope, and matches
the pattern used in dln2_register_event_cb().
Assisted-by: coccinelle sparse
Signed-off-by: Riccardo Oliva <oliva.scorza@xxxxxxxxx>
---
v2:
- Rephrase commit log: Clarified this is a cleanup rather than a bug fix
- Rename 'target' to 'entry' for consistency
drivers/mfd/dln2.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
index 0b1e7fd7f..2a9d83d32 100644
--- a/drivers/mfd/dln2.c
+++ b/drivers/mfd/dln2.c
@@ -157,25 +157,24 @@ EXPORT_SYMBOL(dln2_register_event_cb);
void dln2_unregister_event_cb(struct platform_device *pdev, u16 id)
{
struct dln2_dev *dln2 = dev_get_drvdata(pdev->dev.parent);
- struct dln2_event_cb_entry *i;
+ struct dln2_event_cb_entry *i, *entry = NULL;
unsigned long flags;
- bool found = false;
spin_lock_irqsave(&dln2->event_cb_lock, flags);
list_for_each_entry(i, &dln2->event_cb_list, list) {
if (i->id == id) {
list_del_rcu(&i->list);
- found = true;
+ entry = i;
break;
}
}
spin_unlock_irqrestore(&dln2->event_cb_lock, flags);
- if (found) {
+ if (entry) {
synchronize_rcu();
- kfree(i);
+ kfree(entry);
}
}
EXPORT_SYMBOL(dln2_unregister_event_cb);
--
2.43.0