Re: [PATCH] thunderbolt: stream: Undo more if the start fails

From: Greg Kroah-Hartman

Date: Tue Oct 27 2026 - 10:45:16 EST


On Tue, Oct 27, 2026 at 03:33:25PM +0100, Mika Westerberg wrote:
> Hi,
>
> On Tue, Oct 27, 2026 at 03:24:52PM +0100, Greg Kroah-Hartman wrote:
> > From: Josef Bacik <josef@xxxxxxxxxxxxxx>
> >
> > If the receive buffers cannot be allocated or mapped,
> > tbstream_dev_start() stops and frees the rings, but
> >
> > - leaves the DMA paths through the XDomain connection enabled, with the
> > hop IDs of rings which no longer exist;
> > - does not release the frame array and the pages which
> > tbstream_dev_alloc_rx_buffers() had allocated and mapped before it
> > failed.
> >
> > Fixes: 6db21d817b43 ("thunderbolt: Add support for USB4STREAM")
> > Cc: stable <stable@xxxxxxxxxx>
> > Cc: Andreas Noever <andreas.noever@xxxxxxxxx>
> > Cc: Mika Westerberg <westeri@xxxxxxxxxx>
>
> Do you want to take this directly via USB tree? Then,
>
> Acked-by: Mika Westerberg (Intel) <westeri@xxxxxxxxxx>

I can, thanks!

greg k-h