Re: [PATCH net] pppoe: drop discovery frames with no MAC header
From: Simon Horman
Date: Mon Oct 26 2026 - 13:34:19 EST
On Fri, Oct 23, 2026 at 04:00:00PM +0800, Qingfang Deng wrote:
> Commit 8540827ebac6 ("pppoe: fix reception of frames with no mac
> header") drops PPPoE session frames with no MAC header to avoid reading
> uninitialized memory.
>
> Apply the same to PPPoE discovery frames, as both functions read
> eth_hdr(skb)->h_source.
>
> Found by LLM static analysis, and reproduced using the same TUN
> injection as described in the mentioned commit.
>
> Fixes: 8540827ebac6 ("pppoe: fix reception of frames with no mac header")
> Signed-off-by: Qingfang Deng <qingfang.deng@xxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>