Re: [PATCH v2 0/3] iio: cdc: add Texas Instruments FDC1004 driver

[Victor Chernyakin]

> > > > Changes in v2:
> > > > - Patch 1
> > > >   - Added tests
> > > 
> > > >   - Added a fix in iio_format_value
> > > 
> > > If it's about abs(), it should go  in a separate patch.
> > 
> > This is about both abs() and working around overflow when
> > computing 10^scale. To be clear, neither of these were problems before,
> > they're directly caused by the new units. You're saying they should still
> > go in a separate patch?
> 
> For a starter I'm saying that changelog should be more elaborative.

Now that I read it again, "Added a fix in iio_format_value" really is
quite vague, isn't it? Added more detail in v3.

> But conduct a small research and check if it's possible to split. One fix per
> problem is what we want ideally. However, there are other aspects are being
> involved (in all steps), such as code readability and additional churn made.

I think it makes sense to keep both iio_format_value changes in one patch
since they're so closely related, but I've split them out into a separate
patch from adding the new units.