Re: [PATCH v3] drm/bridge: sii902x: Read "sil,i2s-data-lanes" as u32

From: Maxime Ripard

Date: Mon Oct 26 2026 - 12:14:13 EST


On Mon, Oct 26, 2026 at 10:25:13AM -0500, Rob Herring wrote:
> On Mon, Aug 31, 2026 at 3:32 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> >
> > The "sil,i2s-data-lanes" binding and in-tree DTS files use normal
> > uint32 cells. Reading the array as u8 only works because the values are
> > small, but it does not match the documented DT element size.
> >
> > Use the u32 array helper so the driver follows the binding. Changing to
> > u32 increases a potential OOB access range due to using unchecked
> > values, so add a check on the read values.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > ---
> > v3:
> > - Drop the WARN_ON.
> > - Combine checking the values with any other error parsing the DT
> > property. The exact DT error isn't important.
> >
> > v2:
> > - Add bounds check for property values as reported by sashiko
> > ---
> > drivers/gpu/drm/bridge/sii902x.c | 20 ++++++++++++++------
> > 1 file changed, 14 insertions(+), 6 deletions(-)
>
> Ping. Can I get an ack on this to apply it.

Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>

Alternatively, I can apply it to the drm-misc tree

Maxime

Attachment: signature.asc
Description: PGP signature