Re: [PATCH 4/8] Docs/admin-guide/mm/damon/lru_sort: fix remaining grammar

[Manuel Ebner]

Hi again,

On Mon, 2026-10-26 at 22:14 +1100, Aveline Noir wrote:
> Manuel's recent grammar fix for this file, now in damon/next, covered a
> good part of it.  This should take care of the few mistakes that are
> left, like "should automatically activated" and "Make DAMON_LRU_SORT
> reads".  Rewrap where the lines got too long.
> 
> Signed-off-by: Aveline Noir <jm5905938@xxxxxxxxx>
> ---
>  .../admin-guide/mm/damon/lru_sort.rst         | 45 ++++++++++---------
>  1 file changed, 23 insertions(+), 22 deletions(-)
> 
> diff --git a/Documentation/admin-guide/mm/damon/lru_sort.rst b/Documentation/admin-guide/mm/damon/lru_sort.rst
> index aa4cc90ca57c..c628e3f6e587 100644
> --- a/Documentation/admin-guide/mm/damon/lru_sort.rst
> +++ b/Documentation/admin-guide/mm/damon/lru_sort.rst
> @@ -35,7 +35,7 @@ deprioritizing cold pages on their LRU-lists.  To avoid it consuming too much
>  CPU for the prioritizations, a CPU time usage limit can be configured.  Under
>  the limit, it prioritizes and deprioritizes more hot and cold pages first,
>  respectively.  System administrators can also configure under what situation
> -this scheme should automatically activated and deactivated with three memory
> +this scheme should be automatically activated and deactivated with three memory

Yours isn't wrong but I would make it:
+this scheme should automatically be activated and deactivated with three memory

Choose as you like.

>  pressure watermarks.
>  
>  Its default parameters for hotness/coldness thresholds and CPU quota limit are
> @@ -55,7 +55,7 @@ DAMON_LRU_SORT utilizes module parameters.  That is, you can put
>  ``damon_lru_sort.<parameter>=<value>`` on the kernel boot command line or write
>  proper values to ``/sys/module/damon_lru_sort/parameters/<parameter>`` files.
>  
> -Below are the description of each parameter.
> +Below is the description of each parameter.

My choice : 
+Below are the descriptions of each parameter.


>  ...
Looks good to me.

> 
>  --------------------
> @@ -310,7 +311,7 @@ Total bytes of hot memory regions that were successfully LRU-sorted.
>  nr_hot_quota_exceeds
>  --------------------
>  
> -Number of times that the time quota limit for hot regions have exceeded.
> +Number of times that the time quota limit for hot regions has been exceeded.

I would go for this, but I'm not sure:
+Number of times that the time quota limit for hot regions have been exceeded.

Number of times that ... have been exceeded.

Thanks,
Reviewed-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>

>  ...