Re: [PATCH net] net: dsa: motorcomm: Fix function parameter types

From: Andrew Lunn

Date: Mon Oct 26 2026 - 08:44:52 EST


On Mon, Oct 26, 2026 at 04:32:48PM +0800, David Yang wrote:
> yt921x_fdb_add_index_in12() mistakenly takes the two register images
> as u16, while all registers are 32-bit wide, silently losing the upper
> half. Widen the parameters to u32.

I'm surprised the compiler is not warning about this. Have you tried
building with W=1? or W=2 ?

> Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x")
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew