Re: [PATCH 3/7] media: i2c: ov7251: Add control event support

[Sakari Ailus]

Hi Antoine,

On Mon, Oct 26, 2026 at 08:10:28PM +0900, Antoine Pichot wrote:
> The driver exposes writable controls on its subdev node but does not
> support control events, so VIDIOC_SUBSCRIBE_EVENT fails and
> v4l2-compliance reports:
> 
>   fail: v4l2-test-controls.cpp(1128): subscribe event for control
>   'User Controls' failed
>   test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
> 
> Set V4L2_SUBDEV_FL_HAS_EVENTS and use the standard control event
> helpers, as other sensor drivers do.
> 
> Signed-off-by: Antoine Pichot <antoine.pichot@xxxxxxxxx>

Instead of adding explicit support for events, could you instead make the
driver to use sub-device state? See commit
e8a5b1df000e1a23c04dadbe99621441e0889f88 for an example.

-- 
Kind regards,

Sakari Ailus