Re: [PATCH v22 09/14] media: qcom: camss: vfe: Add support for VFE 1080

[Hangxiang Ma]

On 10/26/2026 6:00 PM, Loic Poulain wrote:
> On Sun, Oct 25, 2026 at 4:17 AM Hangxiang Ma
> <hangxiang.ma@xxxxxxxxxxxxxxxx> wrote:
>>
>> Add support for the VFE (Video Front End) 1080 found on Kaanapali SoC.
>>
[...]
>> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
>> index 7acace363fc2..beca4b827b32 100644
>> --- a/drivers/media/platform/qcom/camss/camss.c
>> +++ b/drivers/media/platform/qcom/camss/camss.c
>> @@ -156,6 +156,152 @@ static const struct camss_subdev_resources csid_res_kaanapali[] = {
>>          }
>>   };
>>
>> +/* In Kaanapali, CAMNOC requires all CPAS_TFEX clocks
>> + * to operate on any TFE Full.
>> + */
>> +static const struct camss_subdev_resources vfe_res_kaanapali[] = {
>> +       /* VFE0 - TFE Full */
>> +       {
>> +               .clock = { "gcc_axi_hf", "cpas_ahb", "cpas_fast_ahb",
>> +                          "vfe0_fast_ahb", "vfe0",
>> +                          "cpas_vfe0", "cpas_vfe1", "cpas_vfe2",
>> +                          "camnoc_rt_axi", "camnoc_nrt_axi", "qdss_debug_xo" },
>
> Now that we have pm_clk in the main camss_resources structure, it
> would make sense to move common/top-level clocks, such as the AHB
> clocks, to it. That would avoid having to duplicate them across each
> individual sub-block.
>

Thanks for pointing this out. I double-checked it, and this makes
perfect sense. I'll move the common/top-level clocks to pm_clk.

---
Best Regards,
Hangxiang