Re: [PATCH 4/4] cpufreq: add an Amlogic speed-bin driver

[Christain Stefan Köver-Draxl]

Hi Viresh,
Hi Jerome,

On 10/26/26 09:59, Viresh Kumar wrote:
> On 26-10-26, 09:57, Jerome Brunet wrote:
> > On lun. 26 oct. 2026 at 11:00, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> >
> > > On 25-10-26, 20:22, christian.koever-draxl@xxxxxxxxxxxxxxxxxx wrote:
> > > > From: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
> > > >
> > > > Every S4 speed bin runs the same CPU frequencies but needs its own
> > > > voltage curve, and the bin can only be read through the secure monitor.
> > > >
> > > > Read the bin from the firmware, select the matching
> > > > "opp-microvolt-speed<bin>" property for all CPUs, then register
> > > > cpufreq-dt. Bins outside the known range fall back to bin 0, which
> > > > has the highest voltages. Like sun50i-cpufreq-nvmem, the driver binds
> > > > on the SoC compatible and needs no node of its own, and S4 is added to
> > > > the cpufreq-dt-platdev blocklist so cpufreq-dt is only created after
> > > > the bin has been applied.
> > > >
> > > > Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
> > > > ---
> > > >   MAINTAINERS                          |   1 +
> > > >   drivers/cpufreq/Kconfig.arm          |  14 ++
> > > >   drivers/cpufreq/Makefile             |   1 +
> > > >   drivers/cpufreq/amlogic-cpufreq.c    | 184 +++++++++++++++++++++++++++
> > > >   drivers/cpufreq/cpufreq-dt-platdev.c |   2 +
> > > >   5 files changed, 202 insertions(+)
> > > >   create mode 100644 drivers/cpufreq/amlogic-cpufreq.c
> > > Is it safe to apply just this one ? I can take this via the PM tree then.
> > I would advise to wait a little for Amlogic to chime in.

Viresh, thanks, but please don't apply it alone. It would need the 
speed-bin call from patch 3 (meson_sm), and without the CPU clock from 
patch 2 it has nothing to scale.

Best regards,
Christian

> Sure, I wasn't going to wait for the maintainers to respond anyway.