Re: [PATCH v32 net-next 6/8] net/nebula-matrix: dispatch: implement channel RPC framework and serialize hardware ops

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Baseline decision: false (resolved later in the series, retained
  only because requires_validation=true).

--

net/nebula-matrix: dispatch: implement channel RPC framework and serialize hardware ops

This patch adds mailbox RPC requests and responders for cfg_msix_map,
destroy_msix_map, set_mailbox_irq, get_vsi_id and get_eth_id. Each op
resolves to a local resource call when has_ctrl is set, or to a channel
RPC to the management PF when has_net is set. The five responders are
registered with the channel layer from nbl_disp_setup_msg().

> nbl_disp_remove() documents why the five responders, which are owned by
> the channel layer, need no explicit unregistration.

[Severity: Low]
Is this paragraph accurate for this patch? The patch does not change
nbl_disp_remove() in nbl_dispatch.c, and at this commit it still reads:

void nbl_disp_remove(struct nbl_adapter *adapter)
{
	/* Dispatch structures are allocated via devm */
}

There is nothing there about the responders that nbl_disp_setup_msg()
registers.

The kernel-doc for struct nbl_dispatch_ops in nbl_def_dispatch.h also sends
readers to nbl_disp_remove() for that explanation:

 * structures are devm-allocated in nbl_disp_init(), and nbl_disp_remove()
 * only documents why no explicit teardown is needed.

The full comment arrives in the next patch in the series, "net/nebula-matrix:
add common/ctrl dev init/remove operation". It explains the teardown order
cancel_work_sync -> nbl_chan_teardown_queue -> nbl_chan_remove_common ->
nbl_chan_remove_msg_handler.

Could this paragraph be dropped from this commit message, or the comment
moved into this patch, so each commit matches its own message?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261021062113.2158-1-illusion.wang%40nebula-matrix.com