Re: [PATCH v3] platform/x86: ideapad-laptop: do not poke keyboard controller
From: Uwe Kleine-König
Date: Fri Oct 23 2026 - 05:25:15 EST
On Wed, Oct 21, 2026 at 09:50:56PM -0700, Dmitry Torokhov wrote:
> On Ideapad Z570 the driver tries to disable and re-enable data coming
> from the touchpad by poking directly into 8042 keyboard controller.
> This may coincide with the controller resuming and leads to spews in
> dmesg and potentially other instabilities.
>
> Instead of using i8042_command() to control the touchpad state create
> an input handler that serves as a filter and drop events coming from
> the touchpad when it is supposed to be off.
>
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
>
> v3:
> - add missing header includes (compiler.h, container_of.h, errno.h,
> mod_devicetable.h, slab.h, spinlock.h)
noooooooo, mod_devicetable.h is wrong, I want to get rid of that header
and input_device_id is already provided by <inux/input.h>.
If you want full iwyu, please use <linux/device-id/input.h> instead.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature