Re: [PATCH 0/3] This series adds support for Texas Instruments OPT4041 Ambient light sensor

[Andy Shevchenko]

On Fri, Oct 23, 2026 at 09:48:12AM +0200, Jesper X Nilsson wrote:
> Extend the opt4001 driver to support OPT4041, since it is so similar to
> OPT4001. The OPT4041 adds a second channel, a wide band channel ranging
> from 380nm to 1000nm. The register map is almost the same for both
> devices. OPT4001 has an internal fifo of size four, OPT4041 has two
> fifos of size two, one for each channel.
> 
> Since OPT4041 has two channels it has one bit in register 0Bh to select
> which channel is compared to the threshold register. The driver does not
> support setting the threshold registers, so no new support has been
> added for this.
> 
> The OPT4041 is pin compatible and has the same package as
> opt4001-sot-5x3. Although the device id is different, I added a new
> compatible string since the driver already had different compatible
> strings to differentiate between the two OPT4001.

Overall very good small series, I have a few comments, but they like 15 minutes
to address, id est mostly style related. I'll give my tag if you send a v2 with
the changes as suggested.

> Datasheet: https://www.ti.com/lit/gpn/opt4041

> 

No blank lines in the tag block :-)

> Signed-off-by: Jesper X Nilsson <jesper.x.nilsson@xxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko