Re: [PATCH net-next v3 5/5] bnge: make NQ0 persistent across open/stop cycles
From: Jakub Kicinski
Date: Thu Oct 22 2026 - 21:16:52 EST
On Thu, 22 Oct 2026 16:27:42 +0530 Bhargava Chenna Marreddy wrote:
> What I propose for v4:
>
> 1. NAPI for NQ0 is added in ndo_open and deleted in ndo_stop, like
> every other NQ.
> 2. NQ0's IRQ stays requested across open/stop:
> - When netdev is UP: The IRQ handler schedules NAPI, which handles
> Rx/Tx, async (including link), and HWRM events.
> - When netdev is DOWN: There is no NAPI instance. The IRQ handler
> queues a work item that handles async and HWRM events.
> 3. Mode switches happen only in open/stop, so only one context
> consumes NQ0 at a time:
> - open: quiesce the IRQ, flush the work item, then enable NAPI.
> - stop: disable NAPI, then allow the work item again.
Sounds reasonable (please note that net-next is closed now)