Re: [PATCH 0/3] ASoC: tas2783-sdw: volume and firmware load fixes

[Lee Mann]

On Sun, 18 Oct 2026 at 21:00, Matthew Schwartz
<matthew.schwartz@xxxxxxxxx> wrote:
>
> Three tas2783-sdw fixes found while bringing up the ASUS ROG Xbox Ally
> X20 [1], whose two TAS2783 amps share a SoundWire link that is powered
> off when idle.

Tested on an ASUS ProArt PX13 HN7306EA (two TAS2783 on one AMD ACP
link), with the series on broonie/sound for-next (686b3eff60) plus
173cb3147ba2 ("ASoC: tas2783-sdw: split a stereo stream across the two
mono amps"), which this machine needs for stereo and which for-next
does not have yet:

- stereo playback after boot, no ASoC or -EBUSY errors in the log
- volume changes while both amps are runtime suspended work, no errors
- after ~2.5 min of s2idle both amps come back at the level set before
  suspend, with nothing done in userspace

The PX13 firmware has no usable SDCA function type, so it takes the
tas2783_init_seq path; the ACPI init table case in patch 3 is not
exercised here.

Tested-by: Lee Mann <leepaulmann@xxxxxxxxx>

One thing you may want to check on the X20: on the PX13, applying the
ACPI init table (via the fallback in thesofproject/linux PR #5904)
together with 173cb3147ba2 left the second amp silent, because the
table puts it on Right while the stereo split hands it a one-channel
payload. If the X20 table also sets a different posture per amp, it
may hit the same once for-next picks up 173cb3147ba2.

Thanks,
Lee