Re: [PATCH v6 0/2] fix two issues in hisi_acc_vfio_pci driver

[Alex Williamson]

On Tue, 13 Oct 2026 15:19:27 +0800
Longfang Liu <liulongfang@xxxxxxxxxx> wrote:

> This series fixes two issues in the HiSilicon ACC VFIO PCI driver:
> 1. A NULL pointer dereference in reset_prepare() when a PF is bound
> to the driver and passed through to a VM.
> 2. A 64KB page incompatibility on QM_HW_V3 hardware that breaks
> migration and the guest kernel.
> 
> Changes since v5:
> - Fix a potential NULL dereference in reset_prepare().
>   Open code &qm->pdev->dev at dev_err() to drop the local variable
>   evaluated before the mig_ops check.
> 
> Changes since v4:
> - Removed dev_err() log from reset_prepare().
> - Removed redundant pdev->is_virtfn check from probe().
> 
> Changes since v3:
> - Merged the set_reset_flag fix into patch 1 (was a separate patch in v3)
> - Replaced pf_qm guards with a mig_ops check at function entry.
> - Moved the 64KB page check from open_device to probe, selecting generic
>   ops instead of rejecting the device.
> 
> Changes since v2:
> - Remove redundant qm->io_base check.
> - Drop PAGE_ALIGN for BAR2 configuration region.
> 
> Longfang Liu (2):
>   hisi_acc_vfio_pci: fix NULL dereference in reset_prepare on PF
>     passthrough
>   hisi_acc_vfio_pci: reject live migration on 64KB page with QM_HW_V3
>     hardware
> 
>  drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 46 ++++++++++++-------
>  1 file changed, 29 insertions(+), 17 deletions(-)
> 

Applied to vfio next branch for v7.4.  Thanks,

Alex