Re: [PATCH v10 3/8] gpio: pl061: drop redundant pending check in the IRQ handler

[Andy Shevchenko]

On Thu, Oct 15, 2026 at 06:53:30PM +0800, Long Zhao via B4 Relay wrote:

> for_each_set_bit() does nothing when the mask is zero, so the
> if (pending) wrapper around it is redundant.

Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

One nit-pick below, though.

...

> +	for_each_set_bit(offset, &pending, PL061_GPIO_NR)
> +		generic_handle_domain_irq(gc->irq.domain,
> +					  offset);

Make it a single line now

		generic_handle_domain_irq(gc->irq.domain, offset);

-- 
With Best Regards,
Andy Shevchenko