Re: [PATCH 3/3] staging: media: atomisp: Fix parameter indentation and block comments
From: Andy Shevchenko
Date: Thu Oct 15 2026 - 15:07:43 EST
On Wed, Oct 14, 2026 at 09:20:59AM -0500, John Singleton wrote:
> Thank you, Andy. Just to confirm from my examination, I think the key
> issues are:
> 1) There should be separate patches for the comment-cleanup and the
> function-header cleanup and
> 2) The preference is to do this for all files in a directory, rather than a
> subset.
>
> Is that a fair summary of the concerns?
Do not top-post!
Not only, the similar patches were sent many times, you need to collect
preliminary work and come up with the best solution out of all.
> On Mon, Oct 12, 2026 at 2:05 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> wrote:
>
> > On Mon, Oct 12, 2026 at 7:13 PM John Singleton <johnsingleton@xxxxxxxxxx>
> > wrote:
> > >
> > > Replace leading spaces with tabs in function parameter lists and
> > > format multi-line comments according to kernel coding style.
> >
> > Please, read the mail archive to understand why this patch is no-go.
--
With Best Regards,
Andy Shevchenko