Re: [PATCH v11 6/7] power: supply: Add driver for ASUS Transformer battery

From: Svyatoslav Ryhel

Date: Thu Oct 15 2026 - 14:42:01 EST


чт, 15 жовт. 2026 р. о 21:06 Markus Elfring <Markus.Elfring@xxxxxx> пише:
>
> …
> > +++ b/drivers/power/supply/asus-transformer-ec-battery.c
> > @@ -0,0 +1,289 @@
> …
> > +static const unsigned int asus_ec_battery_prop_offs[] = {
> > + [POWER_SUPPLY_PROP_STATUS] = 1,
> …
> > +};
> > +
> > +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv,
> > + enum power_supply_property psp)
> > +{
> > + int ret, offs;
> …
>
> The referenced array provides unsigned integers.
> Would you like to specify a more appropriate data type for the corresponding variable?
>

This is a nitpick, it does not affect anything.

> Regards,
> Markus