Re: [PATCH v4 0/2] mm/damon/core: Iterate over installed probes instead of DAMON_MAX_PROBES

From: Suhaas Joshi

Date: Thu Oct 15 2026 - 13:11:52 EST


On Thu, Oct 15, 2026 at 07:29:32AM -0700, SJ Park wrote:
> On Thu, 15 Oct 2026 19:25:23 +0530 Suhaas Joshi <suhaas@xxxxxxxxxx> wrote:
>
> > Hello,
> >
> > This is v4 of a series I sent earlier. Please find changelog below.
> >
> > There were two "todo: " items of the same nature in mm/damon/core.c. Both
> > of these suggested that we should iterate over only installed probes while
> > updating (last_)probe_hits[] during merging/splitting regions, instead of
> > iterating over the entire array, which may have empty/unused indices.
> >
> > So this patch series does exactly that. It replaces the for-loop over
> > [0, DAMON_MAX_PROBES) with a damon_for_each_probe() over the probe list of
> > the context.
>
> Looks good to me, thank you.
>
> I applied this series to damon/next [1] tree. We are now quite close to next
> merge window. It may better to focus on making mm.git more stabilized and
> therefore ready for the next merge window, rather than adding more changes that
> are not really urgent. I understand this series is not really urgent. Hence,
> Andrew might not add this patch until next -rc1 release. In the case, I will
> request adding this to mm.git after next -rc1 release. So, no action from your
> side is needed for now. Let me know if you think this is really urgent.

No, its not urgent at all. We can wait until after -rc1 indeed.

Thanks a lot to you and Liew for the reviews! :)

Regards
Suhaas
>
> [1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
>
>
> Thanks,
> SJ
>
> [...]