Re: [PATCH net-next v2 2/2] net: phy: qcom: qca808x: Add regulator management

From: Andrew Lunn

Date: Thu Oct 15 2026 - 12:43:25 EST


On Thu, Oct 15, 2026 at 11:01:43AM -0500, Alex Elder wrote:
> On 10/15/26 10:40 AM, Lorenzo Bianconi wrote:
> > > + if (count)
> > > + fsleep(phydev->mdio.reset_assert_delay);
> > nit: should we check reset_assert_delay field is actually set?
>
> Are you saying there should be an alternative delay used
> if it is not set? Do you have a suggestion for what to
> use in that case?

Does the binding require the value is set?

What happens it if is 0? I think fsleep() is happy to delay for 0 uS,
but does the hardware still work? Does the datasheet say anything
about power on delays?

Andrew