Re: [PATCH 1/2] EDAC/amd64: Consolidate Family 1Ah model setup
From: Yazen Ghannam
Date: Thu Oct 15 2026 - 12:22:14 EST
On Wed, Oct 14, 2026 at 02:27:19PM +0530, Vishal Badole wrote:
> Every Family 1Ah model uses the v2 UMC register layout, and the driver
> must select it to decode memory errors correctly.
>
> So far each model had to select this itself. That is easy to forget when
> a new model is added, and a single missed flag quietly breaks error
> decoding. The driver also had no check for unknown models, so it would
> load on parts that were never tested and look supported when they are
> not.
>
> Handle the layout once for the whole family so no model can miss it, and
> do not load on models that are not known to work.
>
> Suggested-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Signed-off-by: Vishal Badole <Vishal.Badole@xxxxxxx>
> ---
Boris suggested the 'do not load' idea. That *could* be its own patch
and apply to all the families. IMO applying to all families is not worth
the churn, but splitting the patch is a toss up to me.
Overall, looks good.
Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
Thanks,
Yazen