Re: [PATCH net-next v2 1/2] seg6: skip the route refcount in seg6local IPv6 lookups

[Yuya Kusakabe]

On Thu, 15 Oct 2026 16:30:02 +0200
Gabriel Goller <g.goller@xxxxxxxxxxx> wrote:

> I think we should use ip6_null_entry instead of ip6_blk_hole_entry here.
> Previously this path (failure to acquire the dst ref) was reached through
> ip6_pol_route() and ip6_hold_safe(), which uses ip6_null_entry and returns
> -ENETUNREACH as an error.
> After this patch, the error is triggered here and we use ip6_blk_hole_entry,
> which returns -EINVAL.
>
> What do you think?

Agreed, the error changes.  v3 will drop this fallback altogether:
following Andrea's suggestion, seg6_lookup_nexthop() will keep its
refcounted lookup, so ip6_hold_safe() handles the failure as before.